Registration & Reset password #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ordavidil
commented
Jun 18, 2015
ordavidil
commented
Adding ".idea/" to gitignore.
|
Can you provide a gif that shows the flow please. |
|
Sure,
|
|
|
added 6 commits
June 24, 2015 11:12
|
|
|
The registration flow.
|
| } | ||
| } | ||
| }) | ||
| .state('sign-up', { |
There was a problem hiding this comment.
camelCase (signup, verifyEmail)
added 6 commits
July 9, 2015 17:06
| } | ||
|
|
||
| /** | ||
| * Checking the site settings if a visitor allow to register. |
There was a problem hiding this comment.
Determine if user registration is allowed for ...
| .controller('LoginCtrl', function ($scope, Auth, $state) { | ||
| .controller('LoginCtrl', function ($scope, Auth, $state, Account, accessToken) { | ||
|
|
||
| // Try to verify the email when access token is being passed. |
There was a problem hiding this comment.
- Set the access_token using the
Auth.setAccessToken($stateParams.accessToken) - Please move this to the
stateresolve method and return the result ofAccount.verifyEmail().
// Try to verify the email when access token is being passed.
if ($state.current.name == 'verifyEmail' && accessToken) {
Account.verifyEmail(accessToken).then(function () {
$scope.emailVerified = true;
});
}
|
@ordavidil the changes looks good, Please find out why the test is failing and fix it. |
added 8 commits
August 20, 2015 10:51
|
@amitaibu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.