Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing repeat request in the dashboard. #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: removing repeat request in the dashboard. #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fccc3c
WIP: Removing repeat request in the dashboard.
Feb 17, 2015
281ebf3
docs: correct typo.
Feb 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/templates/client/app/scripts/services/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ angular.module('clientApp')
// Update event broadcast name.
var broadcastUpdateEventName = 'SkeletonEventsChange';

// Cache promises.
var getData = {};


/**
* Return the promise with the events list, from cache or the server.
Expand All @@ -27,11 +30,16 @@ angular.module('clientApp')
*/
this.get = function(companyId, userId) {
var cacheId = companyId + ':' + userId;
if (cache && cache[cacheId]) {
return $q.when(cache[cacheId].data);

// Get cache promise or data.
if (getData[cacheId] || cache[cacheId]) {
getData[cacheId] = $q.when(getData[cacheId] || cache[cacheId].data);
}

return getDataFromBackend(companyId, userId);
// Otherwiose get data from the server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in "Otherwiose"

getData[cacheId] = (getData[cacheId] || getDataFromBackend(companyId, userId));

return getData[cacheId];
};

/**
Expand Down