Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixing the path of the coder scripts inside _travis.yml #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ordavidil
Copy link
Contributor

@ordavidil
Copy link
Contributor Author

@amitaibu
It seems that all files has the execute permission already:
generator-hedley_-__applications_mamp_htdocs_generator-hedley

@ordavidil
Copy link
Contributor Author

This PR also fixing the build by updating npm at the beginning.
:)

@amitaibu
Copy link
Member

Thanks! Can you confirm the build is working properly by scaffolding to another repo - and enabling travis there , as the travis on this repo just checks the generator itself.

@amitaibu
Copy link
Member

btw, I believe that now we have in Gizra a travis installation that runs using Docker. Maybe worth doing the switch of this generator as-well (can be a follow up of course)

@amitaibu
Copy link
Member

I see also an error when running drush @site runserver 127.0.0.1:8080 & since it's not defined anywhere. Bekitzur -- need to run it and see it works ;)

@ordavidil
Copy link
Contributor Author

Basically I've found the issue about the files stats.

          self.fs.write(newFileName, newContents);

doesn't pass the stat of the file.

In a newer version of mem-fs-editor there is an option to pass a stat as well, but I got some other issues on the way, probably because all versions here are not updated.

We probably need to do a lot of refactoring.

I was thinking of adding a bash command for that chmod +x scripts/... but this is only a workaround, it's better to preserve the original stat for each file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants