Always backup live before deployment. #689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano-dagostino
requested changes
Jul 16, 2024
There was a problem hiding this comment.
@dipakmdhrm I would make this optional. For small sites it can work, for bigger sites It can delay the deployment considerably.
AronNovak
reviewed
Jul 20, 2024
| @@ -385,6 +385,9 @@ public function deployPantheonSync(string $env = 'test', bool $do_deploy = TRUE) | |||
| ->stopOnFail(); | |||
|
|
|||
| if ($do_deploy) { | |||
| if ($env == 'live') { | |||
There was a problem hiding this comment.
To actually implement what @mariano-dagostino suggested, add the environment variable to .travis.yml to allow it conditionally. Like DEPLOY_AUTOBACKUP=true or similar, then getenv here. Also mind that we are inside DDEV, so we need to pass it: https://ddev.readthedocs.io/en/stable/users/extend/customization-extendibility/#providing-custom-environment-variables-to-a-container , https://github.com/Gizra/drupal-starter/blob/main/ci-scripts/prepare_deploy.sh#L26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.