Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

Error handling and Translate #172

Merged
merged 21 commits into from
Oct 9, 2017
Merged

Error handling and Translate #172

merged 21 commits into from
Oct 9, 2017

Conversation

amitaibu
Copy link
Member

@amitaibu amitaibu commented Oct 2, 2017

#97

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017 •
edited
Loading

0.6/3h: I've decided to add also the Translation here, so maybe timebox will need some bumping. But currently app is compiling, so next is wiring all to the error handler.

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

0.75/3h: Added also debug property to Config.

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

elm

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

1.5/3h: I'm now moving all text ".. to use translateText

One thing I've done here, is divide the translations strings by topic/module -- so it's easier to cleanup unused strings.

@amitaibu amitaibu changed the title WIP: Error handling and Translate Error handling and Translate Oct 2, 2017
@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

2/3h: All non-debug related text is now under Trans.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

2.5/3h: Added unit tests for the Error module.

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

@AronNovak once this will be green, I'll assign to you to complete the Travis part of WDIO that looks for the debug-errors

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

@bitamar notice that way I've structured Translate.elm -- I think it makes it easier to maintain.

@bitamar
Copy link
Contributor

bitamar commented Oct 2, 2017

@amitaibu - It seems indeed better to have small lists of translations per region. I just wonder what happens when you need the same phrase in two different places, would you duplicate the translation?

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

happens when you need the same phrase in two different places, would you duplicate the translatio

No, maybe I'd move it to another place. Not sure -- I guess we will need to find a use case.

@amitaibu
Copy link
Member Author

amitaibu commented Oct 2, 2017

Travis is green, @AronNovak can you please add the Travis part.

@AronNovak
Copy link
Member

2.75/3h

started to adapt the solution from another project

@AronNovak
Copy link
Member

2.8/3h

finalized the adaptation, next: testing the failure, then reverting it

@AronNovak
Copy link
Member

2.9/3h

Tried to trigger test failure via the new code.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@gizra-robot
Copy link

  • Video of the failed WebdriverIO test login.

@AronNovak
Copy link
Member

the Travis part is settled now

@amitaibu amitaibu merged commit e5d607b into master Oct 9, 2017
@amitaibu amitaibu deleted the 97-error-handling branch October 9, 2017 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@AronNovak AronNovak

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitaibu @gizra-robot @bitamar @AronNovak