Refactor Tables #8
Conversation
Also adding the $gibbon variable to the data sent to getBadges. This is mainly for use of session variables but may be expanded on later on.
… variable, falling back to $_SESSION (old style) - badges_manage now OOified - badges_grant now OOified
- Added expandable column for comment on both badges_grant and badges_manage - Set the width of the badge image to 155px and text to be italic and centred in the column. - Removed TODOs.
|
Awesome, looks like some great progress! It looks like you may have worked on this branch in parallel to the forms 🤔 it appears to be dialing the version increment back rather than forward. Your namespaces also now likely need updated based on the suggested changes from GibbonEdu/core#889 |
|
Namespaces updated, I'll look at the form side of things tomorrow. |
|
Ok I've merged in the changed from before and removed unnecessary changes to the CSS file for good measure. Version has been incremented and changelog updated. |
There was a problem hiding this comment.
Looking good. It appears that in the meantime Ross has leap-frogged you and jumped up to v2.6.00 with some added functionality 😂 It appears that this should work fine with the new changes, but I'm happy to leave that merge to you. Give a shout once you've handled the changes and bumped things up to v2.6.01, then I'll take another look to merge this. Thanks!!
The second part of the saga, merged with master as commited the other day.
The PR brings OOified tables, fixes the bug in #7 , better null variable handling and uses a BadgeDomain to handle queries. This means it relies on GibbonEdu/core#889 being approved because that includes the domain it uses.