Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for macOS arp #93

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fix for macOS arp #93

merged 3 commits into from
Nov 16, 2023

Conversation

raymanP
Copy link
Contributor

@raymanP raymanP commented Oct 19, 2023

Tested and working on macOS.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Code changes:

  • Did you format your code with Black?
    • black getmac tests
  • Are the linting checks passing?
    • tox -e check
  • Do all tests pass locally?
    • tox
  • Have you updated the CHANGELOG with a summary of your change?
  • Did you add your name to the contributors list in the README?

Summary of changes:

  • selects arp regexp by global DARWIN variable instead of testing variants (_regex_std, _regex_darwin), which was not fail proof

@raymanP raymanP changed the title Fix for macOS arp #92 Fix for macOS arp Oct 19, 2023
@GhostofGoes GhostofGoes merged commit 3bc6af1 into GhostofGoes:main Nov 16, 2023
8 of 27 checks passed
@GhostofGoes
Copy link
Owner

Thanks for the fix, and apologies for the delay in approving it. I'll try to get a release out tomorrow while sitting around in the airport.

@raymanP
Copy link
Contributor Author

raymanP commented Nov 20, 2023

Thank you for merging!
Some tests seem to fail under Linux, e.g. in test_methods.py the test_arp_various_args.
There it seem to test under Linux some macOS things. Don't know if it was running before right.

FAILED tests/test_methods.py::test_arp_various_args[58:6d:8f:07:c9:94-192.168.1.1-OSX/arp_-an.out] - AssertionError: assert None == '58:6d:8f:7:c9:94'
FAILED tests/test_methods.py::test_arp_various_args[58:6d:8f:07:c9:94-192.168.1.1-OSX/arp_-a.out] - AssertionError: assert None == '58:6d:8f:7:c9:94'
FAILED tests/test_methods.py::test_arp_various_args[52:54:00:12:35:02-10.0.2.2-solaris10/arp_10-0-2-2.out] - AssertionError: assert None == '52:54:0:12:35:2'

@raymanP
Copy link
Contributor Author

raymanP commented Dec 22, 2023

I added a PR for fixing the test. Now should be good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants