Id mainline updates #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-south
reviewed
Mar 2, 2022
| @@ -10,11 +10,11 @@ def nationbuilder_id | |||
| end | |||
|
|
|||
| def phone | |||
| strip_country_code(@object.landline) | |||
| strip_country_code(@object.phone_numbers.mobile.first) | |||
There was a problem hiding this comment.
Oopsies. This looks to be the wrong field, but I think you picked it up in a later commit.
| end | ||
|
|
||
| def mobile | ||
| strip_country_code(@object.mobile) | ||
| strip_country_code(@object.phone_numbers.landline.first) |
| @@ -34,7 +34,7 @@ def self.push_in_batches(sync_id, members, external_system_params) | |||
| if sync_type === 'tag' | |||
| member_ids.each do |member_id| | |||
| member = Member.find(member_id[:identity_id]) | |||
| member.update_external_id(SYSTEM_NAME, member_id[:nationbuilder_id], {sync_id: sync_id}) if member | |||
| member.update_external_id(SYSTEM_NAME, member_id[:nationbuilder_id]) | |||
There was a problem hiding this comment.
Wouldn't we still need an "if member" here? Or member&.update_external_id(...)?
michael-gratton
force-pushed
the
id-mainline-updates
branch
from
5652204 to
5a54104
Compare
Assume a default id setting exists (this should be set via a corresponding `NATION_BUILDER_DEFAULT_EVENT_CAMPAIGN_ID` setting) and set that on new events if needed.
michael-gratton
force-pushed
the
id-mainline-updates
branch
from
5a54104 to
0ae3d28
Compare
michael-gratton
force-pushed
the
id-mainline-updates
branch
from
0ae3d28 to
abc6f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the engine up-to-date with current Identity mainline