Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated new protobufs for codec negotiation #609

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

martinmitrevski
Copy link
Collaborator

🔗 Issue Links

Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@martinmitrevski martinmitrevski requested a review from a team as a code owner November 29, 2024 13:04
Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@martinmitrevski martinmitrevski enabled auto-merge (squash) November 29, 2024 13:06
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.61 MB 7.61 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

Copy link

sonarcloud bot commented Nov 29, 2024

@martinmitrevski martinmitrevski merged commit 697160c into develop Nov 29, 2024
13 checks passed
@martinmitrevski martinmitrevski deleted the protobuf-codec-negotiation branch November 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants