[Fix]Frame scaled to fill without respecting content mode #596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-494/[alfagift]video-track-appears-stretched-when-the-first-join-livestream
📝 Summary
In some cases it appears that the VideoRenderer doesn't respect the provided contentMode and prefers
scaleToFill
.🛠 Implementation
This revision disables the VideoRendererReusePool until further investigation to understand why it causes this weird behaviour.
🎨 Showcase
before_480.mov
after_480.mov
🧪 Manual Testing Notes
Join multiple livestreams one after another.
☑️ Contributor Checklist