Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Frame scaled to fill without respecting content mode #596

Merged

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Nov 11, 2024

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-494/[alfagift]video-track-appears-stretched-when-the-first-join-livestream

📝 Summary

In some cases it appears that the VideoRenderer doesn't respect the provided contentMode and prefers scaleToFill.

🛠 Implementation

This revision disables the VideoRendererReusePool until further investigation to understand why it causes this weird behaviour.

🎨 Showcase

Before After
before_480.mov
after_480.mov

🧪 Manual Testing Notes

Join multiple livestreams one after another.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Nov 11, 2024
@ipavlidakis ipavlidakis self-assigned this Nov 11, 2024
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 11, 2024

SDK Size

title develop branch diff status
StreamVideo 7.56 MB 7.56 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the fix/previous-call-frame-flashing-when-joining-new-call branch 2 times, most recently from afaa147 to 654a538 Compare November 12, 2024 09:01
@ipavlidakis ipavlidakis marked this pull request as ready for review November 12, 2024 09:22
@ipavlidakis ipavlidakis requested a review from a team as a code owner November 12, 2024 09:22
@ipavlidakis ipavlidakis force-pushed the fix/previous-call-frame-flashing-when-joining-new-call branch from 8967952 to 5302bf1 Compare November 12, 2024 09:23
@ipavlidakis ipavlidakis force-pushed the fix/previous-call-frame-flashing-when-joining-new-call branch from 5302bf1 to 98df67a Compare November 12, 2024 10:46
Copy link

sonarcloud bot commented Nov 12, 2024

@ipavlidakis ipavlidakis enabled auto-merge (squash) November 12, 2024 11:34
@ipavlidakis ipavlidakis merged commit fb5654c into develop Nov 12, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the fix/previous-call-frame-flashing-when-joining-new-call branch November 12, 2024 12:52
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants