[PBE-0] support livestream #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
ipavlidakis
force-pushed
the
livestream
branch
from
f2e1a63
to
d4b0405
Compare
Sources/StreamVideoSwiftUI/Livestreaming/LivestreamPlayer.swift
Outdated
Show resolved
Hide resolved
| roles(), | ||
| joinedAt, | ||
| userId | ||
| combineComparators([ |
There was a problem hiding this comment.
why do we need to change this?
There was a problem hiding this comment.
This one is changed to match React sorting comparators as they seem to have been updated https://github.com/GetStream/stream-video-js/blob/3d115dd349fb0f4c57ff162dbaf829c2f96b45b9/packages/client/src/sorting/presets.ts#L93
ipavlidakis
force-pushed
the
livestream
branch
from
1328ea7
to
2696168
Compare
Generated by 🚫 Danger |
|
martinmitrevski
approved these changes
Nov 20, 2024
| public init( | ||
| type: String, | ||
| id: String, | ||
| muted: Bool = false, | ||
| showParticipantCount: Bool = true, | ||
| joinPolicy: JoinPolicy = .auto, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow starting/joining livestreams from the Demo app
🎨 Showcase
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-12.at.17.05.57.mov
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-12.at.17.10.42.mov
typequery parameter set tolivestream☑️ Contributor Checklist