Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]UI freeze due to access on ghost tracks #538

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Fix]UI freeze due to access on ghost tracks #538

merged 1 commit into from
Sep 23, 2024

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

Resolves the issue where UI may freeze after multiple reconnections.

🧪 Manual Testing Notes

  • On an old device
  • Join a call
  • Perform migrations one after another
  • UI should never freeze

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Sep 23, 2024
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 23, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 23, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 23, 2024 12:25
@ipavlidakis ipavlidakis changed the base branch from develop to feature/reconnection-v2 September 23, 2024 12:26
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.87 MB +475 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -4 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -4 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
110 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

martinmitrevski
martinmitrevski approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried around 10 migrations on iPhone 11 Pro Max, no issues.

@ipavlidakis ipavlidakis merged commit 09c410b into feature/reconnection-v2 Sep 23, 2024
14 of 15 checks passed
@ipavlidakis ipavlidakis deleted the reconnection-v2/fix-ui-freeze-due-to-access-on-ghost-tracks branch September 23, 2024 18:43
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
[Fix]Close transceiver before closing the PeerConnection (#538)
9b30bdf
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
[Fix]Close transceiver before closing the PeerConnection (#538)
2e70e87
ipavlidakis added a commit that referenced this pull request Sep 26, 2024
@ipavlidakis
[Fix]Close transceiver before closing the PeerConnection (#538)
999e11b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski