Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Cancel running tasks on stages when transitioning away #536

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[Fix]Cancel running tasks on stages when transitioning away #536

merged 2 commits into from
Sep 23, 2024

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

Resolves an issue where the call may get disconnected.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Sep 23, 2024
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 23, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 23, 2024
@ipavlidakis ipavlidakis changed the base branch from develop to feature/reconnection-v2 September 23, 2024 11:46
@github-actions GitHub Actions
Copy link

1 Message
📖 Skipping Danger since the Pull Request is classed as Draft/Work In Progress

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 23, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.87 MB +476 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -4 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -4 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis marked this pull request as ready for review September 23, 2024 13:31
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 23, 2024 13:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
110 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis merged commit 9d3ee18 into feature/reconnection-v2 Sep 23, 2024
11 of 13 checks passed
@ipavlidakis ipavlidakis deleted the reconnection-v2/cancel-running-tasks-on-stages-when-transitioning-away branch September 23, 2024 18:44
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
[Fix]Cancel running tasks on stages when transitioning away (#536)
a6856c3 
* [Fix]Cancel stage task to avoid unwanted transitions

* Fix failing tests
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
[Fix]Cancel running tasks on stages when transitioning away (#536)
c467e53 
* [Fix]Cancel stage task to avoid unwanted transitions

* Fix failing tests
ipavlidakis added a commit that referenced this pull request Sep 26, 2024
@ipavlidakis
[Fix]Cancel running tasks on stages when transitioning away (#536)
6247428 
* [Fix]Cancel stage task to avoid unwanted transitions

* Fix failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski