Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Pass all available parameters to connect #528

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[Fix]Pass all available parameters to connect #528

merged 3 commits into from
Sep 18, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Sep 18, 2024 •
edited
Loading

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis requested a review from a team as a code owner September 18, 2024 16:47
@ipavlidakis ipavlidakis self-assigned this Sep 18, 2024
@ipavlidakis ipavlidakis added the bug Something isn't working label Sep 18, 2024
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 18, 2024
@ipavlidakis ipavlidakis changed the title ]pass all available parameters to connect [Fix]Pass all available parameters to connect Sep 18, 2024
@ipavlidakis ipavlidakis changed the base branch from develop to feature/reconnection-v2 September 18, 2024 16:48
@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 18, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.85 MB +455 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -2 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -2 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
109 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis merged commit 6f2ef9a into feature/reconnection-v2 Sep 18, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the fix/pass-all-available-parameters-to-connect branch September 18, 2024 18:45
ipavlidakis added a commit that referenced this pull request Sep 19, 2024
@ipavlidakis
[Fix]Pass all available parameters to connect (#528)
1412868
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
[Fix]Pass all available parameters to connect (#528)
35339d2
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
[Fix]Pass all available parameters to connect (#528)
a06c57b
ipavlidakis added a commit that referenced this pull request Sep 26, 2024
@ipavlidakis
[Fix]Pass all available parameters to connect (#528)
6a52f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski