Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Reconnection #503

Merged
merged 33 commits into from
Sep 26, 2024
Merged

[Feature]Reconnection #503

merged 33 commits into from
Sep 26, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Sep 3, 2024 •
edited
Loading

🔗 Issue Links

Open Tickets

Remaining tasks

  • Re-enable visibilityModifier
  • Centralise request timeout on WebRTCCoordinator + Stages
  • Add tests
  • Add/update documentation
  • Remove observeForceReconnectionRequests observation
  • Rewrite APIs that are using the ObjC API e.g. withUnsafePointer(to: &AssociatedKeys.delegatePublisher)
  • Try to find a way to centralise logging description for SFU events
  • Rethink the need for CallAuthenticator
  • Make DemoApp pointing to Pronto for Debug builds
  • Rename Stream_Video_Sfu_Signal_SignalServer instances to signalService
  • Confirm changeTrackSize is working as expected
  • Re-enable XCTSkipped tests
  • Reduce SDK size

Disabled tests

  • CallController_Tests
  • SFUMiddleware_Tests
  • SFUMiddlewareTests
  • ReconnectionTests.testReconnectingMessage

Skipped tests

  • CallCRUDTests.test_joinBackstageRegularUser

Known Issues

  • Tracks may disappear during the call

Test Suite

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 3, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch 3 times, most recently from 1e4964d to 6224a22 Compare September 4, 2024 15:10
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 4, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.9 MB +509 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB -3 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -3 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch 2 times, most recently from 210e99b to feda9bc Compare September 6, 2024 08:58
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 6, 2024
@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch from 81bdc54 to a8eab2e Compare September 9, 2024 20:22
@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch 5 times, most recently from 197d2fe to 622bd30 Compare September 24, 2024 11:52
@ipavlidakis ipavlidakis changed the title [Feature]Reconnection(Do not merge) [Feature]Reconnection Sep 26, 2024
@ipavlidakis ipavlidakis marked this pull request as ready for review September 26, 2024 12:35
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 26, 2024 12:35
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
5de8964
@ipavlidakis
Add docs and tests for the WebRTC components (#523)
6678c08
@ipavlidakis
Update tests for RTCPeerConnectionCoordinator on handling negotiation…
0be2618 
…/subscriberOffer (#526)
@ipavlidakis
[Fix]Pass all available parameters to connect (#528)
6a52f95
@ipavlidakis
[Fix]Migration failing due to migrationCompleted event not received (#…
014647c 
…527)
@ipavlidakis
Point app to Pronto
2cd87fe
@ipavlidakis
Reenable Callcontroller tests (#529)
df11faa
@ipavlidakis
Fix memory leaks
3c85174
@ipavlidakis
Reenable testReconnectingMessage (#533)
e216e0a
@ipavlidakis
Add more tests for ICEAdapter (#531)
cbdbbfa
@ipavlidakis
Reenable CRDU Test (#532)
7c6a2b3
@ipavlidakis
[Fix]Track orientation issue (#534)
881b101
@ipavlidakis
[Fix]Orientation issue on older devices
b4bc676
@ipavlidakis
[Fix]Close transceiver before closing the PeerConnection (#538)
999e11b
@ipavlidakis
[Fix]Cancel running tasks on stages when transitioning away (#536)
6247428 
* [Fix]Cancel stage task to avoid unwanted transitions

* Fix failing tests
@ipavlidakis
[Fix]Stop SFU event observation during reconnection (#537)
75f6773
@ipavlidakis
[Fix]UI freezing
f636094
@ipavlidakis
Streamline tracks updates on a userInteractive queue
846b4f8
@ipavlidakis
Remove record: true
7a27a2e
@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch from 79f438d to 7a27a2e Compare September 26, 2024 12:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
112 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis merged commit 59f7bfa into develop Sep 26, 2024
13 of 14 checks passed
@ipavlidakis ipavlidakis deleted the feature/reconnection-v2 branch September 26, 2024 20:24
@ipavlidakis ipavlidakis restored the feature/reconnection-v2 branch September 27, 2024 09:20
@ipavlidakis ipavlidakis deleted the feature/reconnection-v2 branch September 27, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski