Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLC]Public interface cleanup #372

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@ipavlidakis ipavlidakis added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 29, 2024
@ipavlidakis ipavlidakis self-assigned this Apr 29, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner April 29, 2024 16:44
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup, especially the @Atomic part 😅

Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@ipavlidakis ipavlidakis force-pushed the improvements/llc-public-interface-cleanup branch from c65f0b6 to 11ecc39 Compare April 30, 2024 10:04
@ipavlidakis
Copy link
Collaborator Author

Local tests results
image

@ipavlidakis ipavlidakis merged commit 985e384 into main Apr 30, 2024
0 of 6 checks passed
@ipavlidakis ipavlidakis deleted the improvements/llc-public-interface-cleanup branch April 30, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants