Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Toggle Transcriptions #358

Merged
merged 5 commits into from
Apr 24, 2024
Merged

[Feature]Toggle Transcriptions #358

merged 5 commits into from
Apr 24, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Apr 24, 2024 •
edited
Loading

Issue

Resolves https://github.com/GetStream/ios-issues-tracking/issues/797

🎯 Goal

Provide an easy way for users to toggle transcription.

📝 Summary

This PR exposes the required API from Call (while updating the DemoApp and Tests) and adds a new Cookbook that explains how to toggle Transcription on/off.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

martinmitrevski
martinmitrevski reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just added few minor things. You also plan to add the cookbook as part of this one, right?

Sources/StreamVideo/Call.swift Outdated Show resolved Hide resolved
Sources/StreamVideo/Call.swift Outdated Show resolved Hide resolved
Sources/StreamVideo/Call.swift Outdated Show resolved Hide resolved
Sources/StreamVideo/Call.swift Outdated Show resolved Hide resolved
@ipavlidakis ipavlidakis force-pushed the docs/transcriptions branch 3 times, most recently from c0f0df5 to 66f971f Compare April 24, 2024 10:08
@ipavlidakis ipavlidakis marked this pull request as ready for review April 24, 2024 12:01
@ipavlidakis ipavlidakis requested a review from a team as a code owner April 24, 2024 12:01
@ipavlidakis ipavlidakis self-assigned this Apr 24, 2024
@ipavlidakis ipavlidakis added the enhancement New feature or request label Apr 24, 2024
@ipavlidakis ipavlidakis enabled auto-merge (squash) April 24, 2024 12:40
@ipavlidakis ipavlidakis force-pushed the docs/transcriptions branch from 3104354 to 7b864a5 Compare April 24, 2024 16:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
58.1% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis merged commit c7fed9e into main Apr 24, 2024
15 checks passed
@ipavlidakis ipavlidakis deleted the docs/transcriptions branch April 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipavlidakis @martinmitrevski