[Redesign] SDK changes #269
Conversation
Generated by 🚫 Danger |
ipavlidakis
force-pushed
the
feature/redesign-sdk-changes
branch
from
d227266 to
31a5a05
Compare
| TopRightView { | ||
| Text(value) | ||
| .minimumScaleFactor(0.3) | ||
| .frame(width: 14, height: 14) |
There was a problem hiding this comment.
Can we make it 16? 😁
There was a problem hiding this comment.
Designers seems to be using values that aren't multiples of 8. Even Apple isn't using multiples of 8 for sizes(button sizes have been historically 44 and 50) but probably only for margins (8 and 16). Even the article states that the point of it is 1. consistency (which means that design will need to be updated to match that) and 2. used for grids and spacing(doesn't mention sizes)
There was a problem hiding this comment.
Ok for size, but I think we should be consistent with paddings - they should be multiplies of 8. Can you also discuss this with the design team?
Sources/StreamVideoSwiftUI/CallView/LayoutComponents/Controls/ModalButton.swift
Show resolved
Hide resolved
...es/StreamVideoSwiftUI/CallView/ViewModifiers/ReadableContentGuide/ReadableContentGuide.swift
Show resolved
Hide resolved
| @@ -97,7 +97,7 @@ struct IncomingCallViewContent: View { | |||
| Button { | |||
| onCallRejected(callInfo.id) | |||
| } label: { | |||
| images.hangup | |||
| Image(systemName: "phone.down.circle.fill") | |||
There was a problem hiding this comment.
Why do we change this?
There was a problem hiding this comment.
Because the Image we have in the Images is now the one without the circle.
There was a problem hiding this comment.
Maybe we can expose a different image, sth like incoming/outgoing hangup?
There was a problem hiding this comment.
Wouldn't that be confusing? Ideally we should be using the same hang up button we have as shared component, right?
Sources/StreamVideoSwiftUI/Utils/ReadableContentGuide/ReadableContentGuide.swift
Outdated
Show resolved
Hide resolved
ipavlidakis
force-pushed
the
feature/redesign-sdk-changes
branch
5 times, most recently
from
5089918 to
48aef00
Compare
There was a problem hiding this comment.
Almost there, we just need to update the padding and some color nits. Also, the CHANGELOG needs to be updated (redesign + the changed methods). Did you check the tutorials (if we use the modified methods there)? We can also release a new minor version after we merge this.
Sources/StreamVideoSwiftUI/CallView/ScreenSharing/ScreensharingControls.swift
Show resolved
Hide resolved
| .resizable() | ||
| .foregroundColor(colors.text) | ||
| .aspectRatio(contentMode: .fit) | ||
| .padding(10) |
There was a problem hiding this comment.
yes, we should fix this, in Figma the padding is 8.
Sources/StreamVideoSwiftUI/CallingViews/MicrophoneCheckView.swift
Outdated
Show resolved
Hide resolved
ipavlidakis
force-pushed
the
feature/redesign-sdk-changes
branch
from
232e724 to
e336ae5
Compare
Co-authored-by: runner <[email protected]>
ipavlidakis
force-pushed
the
feature/redesign-sdk-changes
branch
from
3a173fb to
2dc4424
Compare
|
🎯 Goal
Provide the SDK changes required for the new redesign of the components and Demo App.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
☑️ Contributor Checklist