Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI experience #169

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Improve CI experience #169

merged 1 commit into from
Oct 4, 2023

Conversation

testableapple
Copy link
Collaborator

🔗 Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/513

🎯 Goal

  • - Cache SPM depenencies
  • - Cache iOS Runtimes
  • - Build StreamChat and StreamChatUI only once, and then use it for all apps and targets that need them
  • - Build Test App only once
  • - Do not bootstrap where it's not required

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@testableapple testableapple marked this pull request as ready for review October 3, 2023 18:20
@testableapple testableapple requested a review from a team as a code owner October 3, 2023 18:20
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

martinmitrevski
martinmitrevski reviewed Oct 4, 2023
View reviewed changes
StreamVideo.xcodeproj/project.pbxproj
@@ -4774,6 +4774,7 @@
DEVELOPMENT_ASSET_PATHS = "\"DemoApp/Preview Content\"";
DEVELOPMENT_TEAM = EHV7XZLAHA;
ENABLE_PREVIEWS = YES;
GCC_OPTIMIZATION_LEVEL = s;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which targets have this setting and why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo app in test config, to speed up the build process. Release config has this by default, debug does not because it includes some debug stuff in the build and builds longer.

@testableapple testableapple merged commit 932804f into main Oct 4, 2023
11 of 13 checks passed
@testableapple testableapple deleted the ci/cache-everything branch October 4, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testableapple @martinmitrevski