-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End previous background task as soon as begin task is called #3528
Merged
+30
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
force-pushed
the
fix/background-task-warning
branch
from
December 10, 2024 09:59
4667788
to
e6e47a2
Compare
SDK Size
|
SDK Performance
|
SDK Size
|
laevandus
changed the title
[WIP] End background task as soon as begin task is called
End previous background task as soon as begin task is called
Dec 10, 2024
laevandus
added
🐞 Bug
An issue or PR related to a bug
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
labels
Dec 10, 2024
nuno-vieira
reviewed
Dec 10, 2024
nuno-vieira
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅ I just added a minor feedback to the changelog
martinmitrevski
approved these changes
Dec 10, 2024
Co-authored-by: Nuno Vieira <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 Bug
An issue or PR related to a bug
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-43
🎯 Goal
Make sure previous task is ended when begin task is called immediately.
🛠 Implementation
There have been cases where background tasks are not ended correctly. Although I haven't been able to reproduce this with the demo app, I did find one way to reproduce it. Involves calling begin task twice. Could it be that in some configurations this can happen, not sure.
☑️ Contributor Checklist