-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.37.1 Release #2804
Merged
Merged
4.37.1 Release #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix broken composer input view scrolling after shrinking input * Update CHANGELOG.md
* Fix the unread messages banner showing on new messages * Fix unread messages banner showing on system messages * Fix swiftlint * Update CHANGELOG.md * Update the Unread UI Components whenever the channel is updated * When there is no unread, it should return nil * Revert "Update the Unread UI Components whenever the channel is updated" This reverts commit b247ff0. * Fix logic when the whole message list is unread * Add test coverage * Fix unread badge shown for every new message * Revert fix when sending new messages * Update CHANGELOG.md * PR feedback * Fix Channel Controller Tests
* Fix compilation issues in Apps NSE for Cocoapods * Update CHANGELOG.md
* Fix composer not scrolling to caret position when not animated * Fix frozen scrolling input view when editing message * Scroll to caret position when text changes and caret is out of view * Improve scroll precision when jumping to caret * Fix snapshot tests * Become first responder when editing a message * Fix snapshot tests because of DispatchQueue.main.async * Update CHANGELOG.md * Make sure yoda image is cached for snapshot tests * Fix snapshot tests on CI
* Fix composer input scrolling getting disabled on iOS 17 * Improve precision when scrolling to caret position * Update CHANGELOG.md * Fix composer snapshot tests * Fix snapshot tests that contain composer * Remove jumping to bottom when tapping in shrink input button
#2797) * Keep initial unread message banner * Update jump to unread when channel changes * Make sure we mark as read when receiving new messages and history is read * Fix for message ids that do not belong to the current page * Fix issuw when marking first message in history as unread * Make sure jump to unread is shown when unread count > 0 * Update tests for ChannelController * Add tests for ChatMessageListVC * Add flag to disable unread messages separator through Components * Update documentation for firstUnreadMessageId * Update CHANGELOG * Return nil when firstUnreadMessageId cannot be found * Add option to configure isUnreadMessageSeparatorEnabled from DemoApp * Disable jump to unread in threads * Fix compilation issues on Xcode 13 * Only remove unread count when channel has successfully been marked as read * Do now show mark as unread for own messages * Add consistency between jump to unread and scroll to bottom unread counts
Build for regression testing №123456940 has been uploaded to TestFlight 🎁 |
polqf
approved these changes
Sep 26, 2023
* Do not mark as read when new messages come in and are unseen * Mark as read when tapping scroll to bottom button * Fix tests for ChatChannelVC
Build for regression testing №123456941 has been uploaded to TestFlight 🎁 |
* Reset read for truncated messages * Allow automatic marking as read when discarding unread messages * Make sure we can mark as read if the last message was seen or is currently on screen
Build for regression testing №123456942 has been uploaded to TestFlight 🎁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamChatUI
✅ Added
components.isUnreadMessagesSeparatorEnabled
(Fix unread messages separator disapearing when marking channel as read #2797)🐞 Fixed