Fix Markdown hanging forever #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/StreamChatUI/StreamSwiftyMarkdown/SwiftyMarkdown/SwiftyScanner.swift
Show resolved
Hide resolved
martinmitrevski
approved these changes
Feb 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
nuno-vieira
approved these changes
Feb 27, 2023
Comment on lines
+279
to
+282
|
|
||
| if !shouldAppendStyle && remainingTagsStyle == nil { | ||
| break | ||
| } |
There was a problem hiding this comment.
Can we also create a PR for the original repo? This sounds like a nice defensive additional to the original dependency
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/334
🎯 Goal
Fix issue where an unexpected Markdown pattern was hanging forever due to an issue in SwiftyMarkdown
🛠 Implementation
Forked SwiftyMarkdown, and added a defensive measure so that this scenario does not happen again.
GetStream/SwiftyMarkdown@16b4de5
Updated embedded dependencies so that our SDK has this change.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme