Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some flaky tests #4416

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix some flaky tests #4416

merged 1 commit into from
Dec 16, 2024

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Dec 16, 2024

Geotrek-admin    Run #10621

Run Properties:  status check passed Passed #10621  •  git commit ba1b9b142a ℹ️: Merge 45d9f152d8042e3e410b01520d56be6997a18ba1 into 3dea866f6c86ea31b063275cde57...
Project Geotrek-admin
Branch Review refs/pull/4416/merge
Run status status check passed Passed #10621
Run duration 02m 12s
Commit git commit ba1b9b142a ℹ️: Merge 45d9f152d8042e3e410b01520d56be6997a18ba1 into 3dea866f6c86ea31b063275cde57...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (3dea866) to head (45d9f15).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4416   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         268      268           
  Lines       21290    21290           
=======================================
  Hits        20964    20964           
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos merged commit db4d50d into master Dec 16, 2024
20 checks passed
@submarcos submarcos deleted the fix_some_flaky_tests branch December 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant