-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUG] Fix SchemaRandonneeParser url update (refs #4022) #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinefricou
changed the title
Fix schema randonnee parser url parsing
🐛 [BUG] Fix schema randonnee parser url parsing
Nov 15, 2024
justinefricou
changed the title
🐛 [BUG] Fix schema randonnee parser url parsing
🐛 [BUG] Fix SchemaRandonneeParser url update
Nov 15, 2024
Geotrek-admin Run #10379
Run Properties:
|
Project |
Geotrek-admin
|
Branch Review |
refs/pull/4369/merge
|
Run status |
Passed #10379
|
Run duration | 02m 06s |
Commit |
01d420a124 ℹ️: Merge 353ca8b18943670ebda1a2b759a9e4686055c66c into a763f53d9fe3056d547ca2a9676f...
|
Committer | Justine Fricou |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
22
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4369 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 267 267
Lines 21103 21107 +4
=======================================
+ Hits 20777 20781 +4
Misses 326 326 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
justinefricou
force-pushed
the
fix_SchemaRandonneeParser_url_parsing
branch
3 times, most recently
from
November 15, 2024 15:07
cf0c0de
to
7895e4e
Compare
justinefricou
force-pushed
the
fix_SchemaRandonneeParser_url_parsing
branch
from
November 18, 2024 09:25
7895e4e
to
8fd0b01
Compare
justinefricou
changed the title
🐛 [BUG] Fix SchemaRandonneeParser url update
🐛 [BUG] Fix SchemaRandonneeParser url update (refs #4022)
Nov 18, 2024
Chatewgne
previously requested changes
Nov 20, 2024
justinefricou
force-pushed
the
fix_SchemaRandonneeParser_url_parsing
branch
from
November 22, 2024 15:17
8fd0b01
to
226a9d4
Compare
- fix url being duplicated in description after new import if description is null or was not updated - description and url are now parsed in a filter_description method rather than in the end method
justinefricou
force-pushed
the
fix_SchemaRandonneeParser_url_parsing
branch
from
November 22, 2024 15:22
226a9d4
to
353ca8b
Compare
Chatewgne
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trek
's URL being duplicated during a new import when the newTrek
's description wasnull
or the same as the old descriptionfilter_description
method rather than in theend
methodRelated Issue
Checklist