Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end date to Intervention model (refs #3825) #3853

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Add end date to Intervention model (refs #3825) #3853

merged 8 commits into from
Jan 2, 2024

Conversation

juggler31
Copy link
Contributor

@juggler31 juggler31 commented Dec 12, 2023 •
edited by Chatewgne
Loading

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@juggler31 juggler31 marked this pull request as draft December 12, 2023 10:28
@cypress Cypress
Copy link

cypress bot commented Dec 12, 2023 •
edited
Loading

Passing run #7720 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 5d90c1a into f6ecc55...
Project: Geotrek-admin Commit: da75031dd4 ℹ️
Status: Passed Duration: 02:13 💡
Started: Jan 2, 2024 3:03 PM Ended: Jan 2, 2024 3:06 PM

Review all test suite changes for PR #3853 ↗︎

@juggler31 juggler31 force-pushed the feat_separate_date_into_2_fields branch 4 times, most recently from fb8aa90 to 00f335f Compare December 13, 2023 14:50
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6ecc55) 98.34% compared to head (5d90c1a) 98.34%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3853   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         292      292           
  Lines       22018    22048   +30     
=======================================
+ Hits        21654    21684   +30     
  Misses        364      364

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 force-pushed the feat_separate_date_into_2_fields branch 2 times, most recently from 3cc3c30 to 0475158 Compare December 18, 2023 15:01
@juggler31 juggler31 marked this pull request as ready for review December 18, 2023 15:26
@juggler31 juggler31 requested a review from a team December 18, 2023 15:27
@juggler31 juggler31 force-pushed the feat_separate_date_into_2_fields branch from 0475158 to 6227689 Compare December 18, 2023 16:13
@juggler31 juggler31 changed the title Update maintenance date to have begin & end date Update maintenance date to have begin & end date (#3825) Dec 19, 2023
@juggler31 juggler31 changed the title Update maintenance date to have begin & end date (#3825) Update maintenance date to have begin & end date #3825 Dec 19, 2023
@juggler31 juggler31 changed the title Update maintenance date to have begin & end date #3825 Update maintenance date to have begin & end date (#3825) Dec 19, 2023
@juggler31 juggler31 linked an issue Dec 19, 2023 that may be closed by this pull request
#34 - Interventions - Séparer la date en 2 champs - Date début et Date fin #3825
Closed
@marcantoinedupre
Copy link
Contributor

Small issue with the display of the Intervention fragment on a signage details page. The "End date" column header is squashed without reason.

image

marcantoinedupre
marcantoinedupre approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Chatewgne
Chatewgne requested changes Dec 22, 2023
View reviewed changes
docs/changelog.rst Outdated Show resolved Hide resolved
geotrek/maintenance/filters.py Show resolved Hide resolved
geotrek/infrastructure/filters.py Outdated Show resolved Hide resolved
geotrek/signage/filters.py Outdated Show resolved Hide resolved
geotrek/maintenance/filters.py Show resolved Hide resolved
geotrek/feedback/templates/feedback/report_detail_attributes.html Outdated Show resolved Hide resolved
@Chatewgne Chatewgne force-pushed the feat_separate_date_into_2_fields branch from 180ec49 to d27592b Compare December 29, 2023 16:02
@Chatewgne Chatewgne force-pushed the feat_separate_date_into_2_fields branch from d27592b to f87d00a Compare January 2, 2024 08:48
@Chatewgne Chatewgne force-pushed the feat_separate_date_into_2_fields branch 2 times, most recently from e9c5217 to c5b8dde Compare January 2, 2024 13:04
@Chatewgne Chatewgne force-pushed the feat_separate_date_into_2_fields branch from c5b8dde to 7af5bb8 Compare January 2, 2024 13:39
@Chatewgne Chatewgne force-pushed the feat_separate_date_into_2_fields branch from 7af5bb8 to abe3cc5 Compare January 2, 2024 13:42
@Chatewgne Chatewgne changed the title Update maintenance date to have begin & end date (#3825) Update Intervention model to have begin & end date (refs #3825) Jan 2, 2024
@Chatewgne Chatewgne changed the title Update Intervention model to have begin & end date (refs #3825) Add end date to Intervention model (refs #3825) Jan 2, 2024
@Chatewgne Chatewgne merged commit efc9d7b into master Jan 2, 2024
15 checks passed
@Chatewgne Chatewgne deleted the feat_separate_date_into_2_fields branch January 2, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chatewgne Chatewgne Chatewgne requested changes

@marcantoinedupre marcantoinedupre marcantoinedupre approved these changes

Assignees
No one assigned
Labels
✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#34 - Interventions - Séparer la date en 2 champs - Date début et Date fin
3 participants
@juggler31 @marcantoinedupre @Chatewgne