-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle case where year is none when loading signage - #3611 #3746
Conversation
The changelog is at |
Passing run #7253 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
2cc20d1
to
f160e88
Compare
Thanks, I edited it. |
Thanks @roipoussiere for this contribution ! 🙏 The team will review the code to ensure everything is fine and if the pipeline succeed then it's okay for me to merge it. |
f160e88
to
e091c0c
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3746 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 291 291
Lines 21727 21732 +5
=======================================
+ Hits 21362 21367 +5
Misses 365 365
☔ View full report in Codecov by Sentry. |
09b13b8
to
ee824fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have started the CI with your changes.
Looks good, thanks! 👍
ee824fd
to
3d4d622
Compare
My rebase caused the duplication the Bug fixes section the changelog, I force-pushed the fix. |
This PR handles the case where the year is None when loading a signage.
Description
I also added a utility function in the tests in order to allow to use a modified version of the ShapeFile used for tests.
Related Issue
#3611
Checklist