Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where year is none when loading signage - #3611 #3746

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

njourdane
Copy link
Contributor

@njourdane njourdane commented Sep 26, 2023

This PR handles the case where the year is None when loading a signage.

Description

I also added a utility function in the tests in order to allow to use a modified version of the ShapeFile used for tests.

Related Issue

#3611

Checklist

@marcantoinedupre
Copy link
Contributor

The changelog is at docs/changelog.rst.

@cypress
Copy link

cypress bot commented Sep 27, 2023

Passing run #7253 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 3d4d622 into a4c5e4b...
Project: Geotrek-admin Commit: b5482af58c ℹ️
Status: Passed Duration: 06:31 💡
Started: Sep 27, 2023 5:09 PM Ended: Sep 27, 2023 5:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@njourdane njourdane force-pushed the bug_signage_none_year branch from 2cc20d1 to f160e88 Compare September 27, 2023 07:11
@njourdane
Copy link
Contributor Author

Thanks, I edited it.

@babastienne babastienne requested a review from a team September 27, 2023 07:21
@babastienne
Copy link
Member

Thanks @roipoussiere for this contribution ! 🙏

The team will review the code to ensure everything is fine and if the pipeline succeed then it's okay for me to merge it.

@njourdane njourdane force-pushed the bug_signage_none_year branch from f160e88 to e091c0c Compare September 27, 2023 07:55
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a4c5e4b) 98.32% compared to head (3d4d622) 98.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3746   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files         291      291           
  Lines       21727    21732    +5     
=======================================
+ Hits        21362    21367    +5     
  Misses        365      365           
Files Coverage Δ
geotrek/signage/management/commands/loadsignage.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njourdane njourdane force-pushed the bug_signage_none_year branch from 09b13b8 to ee824fd Compare September 27, 2023 16:20
@marcantoinedupre marcantoinedupre self-requested a review September 27, 2023 16:38
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have started the CI with your changes.

Looks good, thanks! 👍

@njourdane njourdane force-pushed the bug_signage_none_year branch from ee824fd to 3d4d622 Compare September 27, 2023 16:46
@njourdane
Copy link
Contributor Author

njourdane commented Sep 27, 2023

My rebase caused the duplication the Bug fixes section the changelog, I force-pushed the fix.

@submarcos submarcos merged commit f239b67 into GeotrekCE:master Sep 28, 2023
@njourdane njourdane deleted the bug_signage_none_year branch September 28, 2023 10:03
@babastienne babastienne changed the title 🐛 [Bug fixes] handle case where year is none when loading signage - #3611 Handle case where year is none when loading signage - #3611 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants