Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor accessibility attachments #3744

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

submarcos
Copy link
Member

Description

Clean code part for accessibilty attachments

@cypress
Copy link

cypress bot commented Sep 26, 2023

Passing run #7232 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 114d568 into 4ec2b62...
Project: Geotrek-admin Commit: 4c05b88ce7 ℹ️
Status: Passed Duration: 03:41 💡
Started: Sep 26, 2023 10:02 AM Ended: Sep 26, 2023 10:05 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5c9d344) 98.31% compared to head (114d568) 98.31%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3744   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         291      291           
  Lines       21725    21725           
=======================================
  Hits        21360    21360           
  Misses        365      365           
Files Coverage Δ
geotrek/common/forms.py 98.65% <100.00%> (ø)
geotrek/common/urls.py 100.00% <100.00%> (ø)
geotrek/urls.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos marked this pull request as ready for review September 26, 2023 11:57
@submarcos submarcos requested a review from a team September 26, 2023 11:57
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

If convenient could you squash the 2 commits?

@submarcos submarcos merged commit f8f6a7e into master Sep 26, 2023
@submarcos submarcos deleted the refactor_accessibility_attachments branch September 26, 2023 14:16
submarcos added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants