-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixture rules of sensitive area #3470 #3721
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3721 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 292 292
Lines 21792 21792
=======================================
Hits 21429 21429
Misses 363 363 ☔ View full report in Codecov by Sentry. |
Passing run #7590 ↗︎
Details:
Review all test suite changes for PR #3721 ↗︎ |
geotrek/sensitivity/fixtures/upload/FEEDINGWILDLIFE-FORBIDDEN_036.svg
Outdated
Show resolved
Hide resolved
geotrek/sensitivity/fixtures/upload/PICKING-FUNGI-FORBIDDEN_070.svg
Outdated
Show resolved
Hide resolved
985d7b3
to
71d466e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juste one more line to remove and then it seems good to me
Pour information quel devrait être le message de mon commit pour répondre correctement à la tache "My commits are all using prefix convention (emoji + tag name) and references associated issues" ? |
Normalement les infos sont maintenant sur https://geotrek.readthedocs.io/en/latest/CONTRIBUTING.html#pull-requests |
@amandine-sahl puisqu'il s'agit d'un improvement je dirais de le formuler au choix parmi les propositions suivantes :
Le prefix (émoji et/ou tagname) est là pour identifier en un coup d'oeil le périmètre d'un développement. |
9ea9c2c
to
427f8cf
Compare
@amandine-sahl il y a un conflit qui nous empêche de merger ta PR. Peux-tu fixer le conflit et me pinger quand c'est fait ? Ensuite de mon côté c'est ok pour merger. |
427f8cf
to
b790375
Compare
@babastienne le conflit a été résolu |
b790375
to
ab4e5e4
Compare
4853ec2
to
0ce3391
Compare
Description
Ajout d'une fixture règle pour les zones sensibles.
Manque les pictogrammes pour les 4 règles suivantes :
Related Issue
#3470
Checklist