Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove review field from ServiceType model (#1669) #3683

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

babastienne
Copy link
Member

Description

This pull request remove the field "review" used in ServiceType.

Related Issue

Fix #1669

Checklist

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bb42642) 98.29% compared to head (c2573d3) 98.29%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3683   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         292      292           
  Lines       21735    21736    +1     
=======================================
+ Hits        21365    21366    +1     
  Misses        370      370           
Files Changed Coverage Δ
geotrek/trekking/models.py 96.29% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babastienne babastienne force-pushed the impr_servicetype_review branch from d37d974 to 1ab7c70 Compare September 5, 2023 19:00
@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #7030 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge c2573d3 into bb42642...
Project: Geotrek-admin Commit: c417670ae3 ℹ️
Status: Passed Duration: 03:55 💡
Started: Sep 6, 2023 9:18 AM Ended: Sep 6, 2023 9:22 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@babastienne babastienne force-pushed the impr_servicetype_review branch from 1ab7c70 to c2573d3 Compare September 6, 2023 09:04
@babastienne babastienne requested a review from a team September 6, 2023 12:24
@babastienne babastienne merged commit 7bd79d4 into master Sep 6, 2023
@babastienne babastienne deleted the impr_servicetype_review branch September 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service type - Published ?
2 participants