Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dead link for itinerant trek exemple #3680

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

bruhnild
Copy link
Contributor

@bruhnild bruhnild commented Sep 5, 2023

No description provided.

@bruhnild bruhnild self-assigned this Sep 5, 2023
@bruhnild bruhnild requested a review from babastienne September 5, 2023 10:10
@babastienne babastienne changed the title remplacement lien mort itinérance gte Remplacement lien mort itinérance gte Sep 5, 2023
@@ -37,6 +37,7 @@ CHANGELOG

- Add configuration file for readthedocs
- Update architecture schema
- Replace broken link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta modification est dans la prochaine release, pas dans la 2.100. Il faut déplacer cette ligne dans la section du changelog correspondante à la prochaine release (la section 2.100.0+dev (XXXX-XX-XX))

@babastienne
Copy link
Member

Essaye de faire un unique commit pour tes modifications et de le nommer en respectant les recommandations :
📝 [DOC] Replace dead link for itinerant trek exemple

Essaye de rédiger les commits et les titres de PR en Anglais.

@babastienne babastienne changed the title Remplacement lien mort itinérance gte Replace dead link for itinerant trek exemple Sep 5, 2023
@bruhnild
Copy link
Contributor Author

bruhnild commented Sep 5, 2023

J'ai le minimum de bases en git et renommer/fusionner un commit n'en fait pas partie. À la prochaine PR j'appliquerai les bonnes pratiques du premier coup.

@babastienne babastienne merged commit cd783db into master Sep 5, 2023
@babastienne babastienne deleted the mfu-update-doc branch September 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants