Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPI-3501 bug fix for issue introduced with improved input checks #55

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

treefern
Copy link
Collaborator

This addresses a refactoring issue introduced in #54 and published as pre-release 0.0.57.dev1
It also adds some minor doc/commenting improvements.

@treefern treefern requested a review from ronaldmaj September 18, 2024 07:44
@treefern treefern self-assigned this Sep 18, 2024
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, happy for this to go in. From what I can see, this has some clarifying documentation and a fix to the read_nanu function

@ronaldmaj ronaldmaj merged commit bd9c1e8 into main Sep 20, 2024
4 checks passed
@treefern treefern deleted the NPI-3501-bug-fix-for-better-input-checks branch October 4, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants