Restoring backward compatibilities #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions 3.9 and above
ronaldmaj
requested changes
Sep 4, 2024
There was a problem hiding this comment.
These changes look great. Also really like that we are now testing these unit tests across various Python versions - this is a really nice addition.
I've tested this locally on some functions, seem to work well.
The one thing that is coming along for the ride here is a number of black changes that I don't think should be coming through.
Namely, compression of lines. We've used line-width = 120 characters for other pushes, so some of the changes in here I don't think should come through if we continue to use that convention
ronaldmaj
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the code to make the package compatible for python 3.9 again.
Python 3.9 is the default install on Apple MacOS, it's end of life is in October 2025.
Main changes are:
|operator toUniona few other fixes/simplification the time I was doing it.