Skip to content

Commit

Permalink
NPI-3669 add notes on important unit tests which remain to be added t…
Browse files Browse the repository at this point in the history
…o test_sp3.py
  • Loading branch information
treefern committed Dec 24, 2024
1 parent 48c3701 commit 8f45be9
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions tests/test_sp3.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ def test_read_sp3_header_svs_detailed(self):
end_line2_acc, 18, msg="Last ACC on test line 2 (pos 30) should be 18"
)

# TODO Add test(s) for correctly reading header fundamentals (ACC, ORB_TYPE, etc.)
# TODO add tests for correctly reading the actual content of the SP3 in addition to the header.
# TODO add tests for correctly generating sp3 output content with gen_sp3_content() and gen_sp3_header()

def test_sp3_clock_nodata_to_nan(self):
sp3_df = pd.DataFrame(
{("EST", "CLK"): [999999.999999, 123456.789, 999999.999999, 987654.321]}
Expand Down Expand Up @@ -176,6 +180,7 @@ def test_velinterpolation(self, mock_file):
"""
Checking if the velocity interpolation works, right now there is no data to validate, the only thing done
is to check if the function runs without errors
TODO: update that to check actual expected values
"""
result = sp3.read_sp3("mock_path", pOnly=True)
r = sp3.getVelSpline(result)
Expand Down Expand Up @@ -300,6 +305,11 @@ def test_trim_df(self, mock_file):
"Should be two epochs after trimming with keep_first_delta_amount parameter",
)

# Don't bother trying to unit test transform_df(). It is a wrapper which basically does:
# - read (parse)
# - apply function
# - write (generate content)
# TODO notes added above to implement those bits separately

class TestMergeSP3(TestCase):
def setUp(self):
Expand Down

0 comments on commit 8f45be9

Please sign in to comment.