Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model handling, support modelling with "all" models #26

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Nov 12, 2024

Changes

  • Add new "all" option to model param, which will model tides using all available tide models in your provided directory
  • Move model list handling to a separate utils function _standardise_models, which handles providing models as strings or lists, as well as handling custom "all" and "ensemble" options

Bug fixes

  • Fix bug where GOT5.6 was not detected as a valid model because it contains files in multiple directories (both "GOT5.6" and "GOT5.5"

image

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (56beb4c) to head (b0ec3f8).

Files with missing lines Patch % Lines
eo_tides/utils.py 62.5% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #26     +/-   ##
=======================================
- Coverage   81.5%   81.3%   -0.2%     
=======================================
  Files          6       6             
  Lines        622     632     +10     
  Branches     107     110      +3     
=======================================
+ Hits         507     514      +7     
- Misses        69      71      +2     
- Partials      46      47      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbibt robbibt merged commit b3ed54a into main Nov 13, 2024
11 checks passed
@robbibt robbibt deleted the refactor_model_handling branch November 13, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants