Fix version number formatting in edge cases #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
benji-glitsos-ga
commented
Dec 15, 2024
•
benji-glitsos-ga
commented
- This PR fixes a problem on DEA Fractional Cover (Landsat) where the version number is displaying as "vLandsat 5/7: 2.5.0, Landsat 8/9: 2.5.1" instead of "Landsat 5/7: 2.5.0, Landsat 8/9: 2.5.1"
- Enable version number formatting to handle cases where the version number is a string that isn't a normal number like "1.0.0"
- An example of a product page where this is needed - notice how most version numbers start with "v" but not the one that instead starts with "Landsat" since that one wouldn't make sense if we appended a "v" ("vLandsat"): https://pr-357-preview.khpreview.dea.ga.gov.au/data/product/dea-fractional-cover-landsat/?tab=history
Preview is ready!
You can also view the deploy log or read the documentation. |
benji-glitsos-ga
deleted the
feature/fix-version-history-string-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.