Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow deletion of entry node #583

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Do not allow deletion of entry node #583

merged 8 commits into from
Oct 3, 2023

Conversation

capital-G
Copy link
Member

@capital-G capital-G commented Sep 22, 2023 •
edited by vin-ni
Loading

Aims to close #439

  • Backend
  • Frontend

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

File Coverage
All files 82% ✅
gencaster/db_logging.py 96% ✅
gencaster/distributor.py 68% ✅
gencaster/schema.py 55% ✅
gencaster/urls.py 76% ✅
osc_server/models.py 91% ✅
osc_server/server.py 55% ✅
story_graph/engine.py 84% ✅
story_graph/markdown_parser.py 91% ✅
story_graph/models.py 97% ✅
story_graph/types.py 93% ✅
stream/frontend_types.py 94% ✅
stream/models.py 92% ✅
stream/types.py 99% ✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 5de83f0

@vin-ni
Copy link
Member

vin-ni commented Sep 23, 2023

@capital-G
Updated frontend and checked backend code. Fine from my side to merge.

@vin-ni vin-ni self-requested a review September 23, 2023 01:03
vin-ni
vin-ni approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@vin-ni vin-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

vin-ni
vin-ni reviewed Sep 23, 2023
View reviewed changes
caster-editor/src/components/Menu.vue Outdated
import { ref, type Ref } from "vue";
import { Tab, useInterfaceStore } from "@/stores/InterfaceStore";
import MenuTab from "./MenuTabHeader.vue";
import MenuTabEdit from "./MenuTabEdit.vue";
import MenuTabPlay from "./MenuTabPlay.vue";
import DialogExitGraph from "./DialogExitGraph.vue";

export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName">;
export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName"> & {
Copy link
Member

@vin-ni vin-ni Sep 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy about this. What do you think @capital-G ?

export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName"> & { nodes: Array<any>; };

@capital-G capital-G merged commit fa0c6a4 into main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vin-ni vin-ni vin-ni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not allow to delete the start node
2 participants
@capital-G @vin-ni