-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
418 update to typescript 5 & update @vue/tsconfig #435
base: main
Are you sure you want to change the base?
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1b623c4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too sure that node is the proper resolution method when reading the changelog of ts5.
It seems node
is somehow deprecated and should be used for comparability if one writes a library.
@@ -2,6 +2,7 @@ | |||
"extends": "./tsconfig.app.json", | |||
"exclude": [], | |||
"compilerOptions": { | |||
"moduleResolution": "node", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citing https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler
If you are using a modern bundler like Vite, esbuild, swc, Webpack, Parcel, and others that implement a hybrid lookup strategy, the new bundler option should be a good fit for you.
As we are using Vite we should maybe use bundler
? :) But I don't understand too much of it I must admit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just readt the referenced issue - this seems a bug in ElementPlus, so maybe block the upgrade to TS5 until they have EP fixed their bug for TS5? Or is it necessary to upgrade to TS5? Switching to node
resolution seems like a hack to me if TS advises to use bundler
, especially since node
seems somehow deprecated in favour of nodenext
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put it on hold then
typescript 5
@vue/tsconfig
to fix theimportsNotUsedAsValues
bug@vue/tsconfig
routes