Fix openretro rating calculation (#99)

Gemba · Nov 27, 2024 · 5500a32 · 5500a32
1 parent aea3e4b
commit 5500a32
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -26,6 +26,7 @@ humans](https://keepachangelog.com).
   `/home/<USER>/.skyscraper/whdload_cached_etag.txt` will force a new download.
 - Fixed: Performing Ctrl-C in `--cache edit` mode will now dismiss any changes
   made instead of persisting them
+- Fixed: Game rating calculation in Openretro scraping module
 
 ### Version 3.13.0 (2024-11-06)
 

diff --git a/src/openretro.cpp b/src/openretro.cpp
@@ -28,6 +28,7 @@
 #include "nametools.h"
 #include "strtools.h"
 
+#include <QDebug>
 #include <QRegularExpression>
 
 OpenRetro::OpenRetro(Settings *config, QSharedPointer<NetManager> manager)
@@ -244,7 +245,7 @@ void OpenRetro::getRating(GameEntry &game) {
     bool ratingDecimal = true;
 
     if (checkNom(ratingPre.at(0))) {
-        // "0 ... 100%" or "n/d" (from mags/ext. websites)
+        // "0 ... 100%" or "numerator/denominator" (from mags or ext. websites)
         nomNom(ratingPre.at(0));
         nomNom(ratingPre.at(1));
         ratingDecimal = false;
@@ -258,6 +259,8 @@ void OpenRetro::getRating(GameEntry &game) {
 
     bool toDoubleOk = false;
     game.rating = data.left(data.indexOf(ratingPost.toUtf8()));
+    qDebug() << "game.rating" << game.rating;
+    qDebug() << "ratingDecimal" << ratingDecimal;
 
     if (!ratingDecimal) {
         if (game.rating.endsWith("%")) {
@@ -268,7 +271,7 @@ void OpenRetro::getRating(GameEntry &game) {
             if (toDoubleOk) {
                 double den = parts.value(1).toDouble(&toDoubleOk);
                 if (toDoubleOk && den > 0.0) {
-                    game.rating = QString::number(num / den);
+                    game.rating = QString::number(num / den, 'g', 2);
                     return;
                 }
             }
@@ -280,7 +283,7 @@ void OpenRetro::getRating(GameEntry &game) {
 
     double rating = game.rating.toDouble(&toDoubleOk);
     if (toDoubleOk) {
-        game.rating = QString::number(rating / (ratingDecimal ? 10.0 : 1.0));
+        game.rating = QString::number(rating / (ratingDecimal ? 1.0 : 100.0));
     } else {
         game.rating = "";
     }