Merge pull request #22 from Gavant/change-chromium

Update chromium and node

.github/workflows/ci.yml

@@ -20,10 +20,10 @@ jobs:
             - uses: actions/checkout@v3
             - uses: volta-cli/action@v1
               with:
-                  node-version: 14.x
+                  node-version: 18.x
                   yarn-version: 1.x
             - name: Install Dependencies
-              run: yarn install --frozen-lockfile
+              run: yarn install
             - name: Lint
               run: yarn lint
             - name: Run Tests

.gitignore

@@ -6,5 +6,6 @@
 .idea/*
 
 .DS_Store
+.yarn
 coverage
 *.log

.npmignore

@@ -10,6 +10,7 @@
 coverage
 *.log
 .gitlab-ci.yml
+.yarn
 
 yarn.lock
 /*.tgz

.yarnrc.yml

@@ -0,0 +1 @@
+nodeLinker: node-modules

package.json

@@ -42,14 +42,15 @@
     "dependencies": {
         "@aws-sdk/client-s3": "^3.56.0",
         "@aws-sdk/s3-request-presigner": "^3.120.0",
-        "chrome-aws-lambda": "^10.1.0",
+        "@sparticuz/chromium": "122",
         "puppeteer-core": "^13.5.1",
         "puppeteer-report": "^3.0.2"
     },
     "publishConfig": {
         "access": "public"
     },
     "volta": {
-        "node": "14.19.1"
+        "node": "18.16.0",
+        "yarn": "3.6.4"
     }
 }

src/services/pdf-generation.ts

@@ -1,7 +1,8 @@
-import chromium from 'chrome-aws-lambda';
-import { PDFOptions } from 'puppeteer-core';
+import puppeteer, { PDFOptions } from 'puppeteer-core';
 import report from 'puppeteer-report';
 
+import chromium from '@sparticuz/chromium';
+
 import PdfGenerationRequest from '../requests/request';
 
 const DEFAULT_PRINT_OPTIONS: PDFOptions = {
@@ -29,7 +30,7 @@ export default class PdfGenerationService {
         });
         console.log(`Puppeteer visited page located at ${pdfGenerationRequest.url}`);
         const options = { ...htmlToPdfPrintOptions, ...pdfGenerationRequest.pdfOptions };
-        await report.pdfPage(page, {
+        await report.pdfPage(page as any, {
             path: pdfGenerationRequest.localFilePath,
             ...options
         });
@@ -40,13 +41,14 @@ export default class PdfGenerationService {
     }
 
     async launchBrowser(pdfGenerationRequest: PdfGenerationRequest) {
-        return await chromium.puppeteer.launch({
+        const chromiumPath = await chromium.executablePath();
+        const options = {
             args: chromium.args,
-            defaultViewport: null,
-            executablePath: await chromium.executablePath,
-            headless: chromium.headless,
-            ignoreHTTPSErrors: true,
+            executablePath: chromiumPath,
+            headless: !!process?.env?.BROWSER_HEADLESS === false ? false : true,
             ...pdfGenerationRequest.browserOptions
-        });
+        };
+
+        return await puppeteer.launch(options);
     }
 }