Update PowerSelect API #61
Conversation
The recent changes to the ember-power-select types left out a number of options that are documented in the API reference: https://2-x.ember-power-select.com/docs/api-reference/
|
Hi @kpfefferle - thanks for this. But many of these arguments no longer exist in the current codebase. 2.x is quite old - they are on 6.x now. I will go through and try to fix any I missed (or your welcome to do it using the code here! https://github.com/cibernox/ember-power-select/blob/master/addon/components/power-select.hbs ) but otherwise I would recommend taking these args and using Another option that might be viable is to create a Thoughts? |
|
@bakerac4 That's a good catch. I ran into this because there are a number of arguments we use that are documented here but weren't included in the new types. These are probably arguments that you noted are "only accessed from the template"? We certainly use some of these and need them to be included. I'll update my PR from the current docs instead of 2.x 🤦♂️ |
|
@bakerac4 I updated based on the current API documentation: https://ember-power-select.com/docs/api-reference The only change was the addition of |
I'm not sure where you're getting this idea from. I just searched for every one of these arguments, and they all exist in the current codebase 🤔 |
Taking a look. |
|
@bakerac4 Seems reasonable. Done ✅ |
|
Any updates on this? We're tying to set up glint in our addon, and there are a lot of errors with ember-power-select which this will hopefully solve |
The recent changes to the ember-power-select types left out a number of options that are documented in the API reference: https://2-x.ember-power-select.com/docs/api-reference/