Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explicit references to pytz [#184132800] #629

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

uraniumanchor
Copy link
Collaborator

Contributing to the Donation Tracker

  • I've added tests or modified existing tests for the change.
  • I've humanly end-to-end tested the change by running an instance of the tracker.

Issue from Pivotal Tracker

https://www.pivotaltracker.com/story/show/184132800

Description of the Change

For reasons I can't entirely remember, there are some odd conflicts we were running into with tzdata and such that required pinning old versions, which are also blocking some PRs from passing via autobumps.

zoneinfo is the official way to handle timezones, but it's only supported in Python 3.9 or higher. 3.8 has a backports package available.

I took the time to remove all explicit references to pytz (and by extension, tzdata), and cleaned up some time processing code at the same... time.

Verification Process

Most of it was fairly mechanical and was covered by the tests, I did make sure that sending a donation still worked since there was some rather dubious explicit filling in of the timestamp when the default value should have been just fine.

faultyserver
faultyserver previously approved these changes Dec 6, 2023
Copy link
Member

@faultyserver faultyserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always glad to be able to get rid of explicit timezone references, and dropping some dependencies and removing extra utils is always great, too

@uraniumanchor uraniumanchor force-pushed the 184132800-remove-pytz branch 2 times, most recently from 1af267d to 0b4b33a Compare December 6, 2023 21:29
@uraniumanchor uraniumanchor added this pull request to the merge queue Dec 6, 2023
Merged via the queue into master with commit 3a6e92c Dec 6, 2023
15 checks passed
@uraniumanchor uraniumanchor deleted the 184132800-remove-pytz branch December 6, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants