remove explicit references to pytz [#184132800] #629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Donation Tracker
Issue from Pivotal Tracker
https://www.pivotaltracker.com/story/show/184132800
Description of the Change
For reasons I can't entirely remember, there are some odd conflicts we were running into with tzdata and such that required pinning old versions, which are also blocking some PRs from passing via autobumps.
zoneinfo
is the official way to handle timezones, but it's only supported in Python 3.9 or higher. 3.8 has a backports package available.I took the time to remove all explicit references to pytz (and by extension, tzdata), and cleaned up some time processing code at the same... time.
Verification Process
Most of it was fairly mechanical and was covered by the tests, I did make sure that sending a donation still worked since there was some rather dubious explicit filling in of the timestamp when the default value should have been just fine.