-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic models for Plugin Config #899
Pydantic models for Plugin Config #899
Conversation
I skimmed through it, happy to review when you think it's ready. I would stick with either BTW, |
Yep! I leaned pydantic while working on the RP merge, which has a by far more complex set of models. I've been using ..and yes I fear the update to pydantic 2 when I'll have to redo everything :( |
I can't find any reference to |
When the key path ("gm4.versioning") doesn't exist, beet falls back to just "gm4", which is dumb and had different data entirely
I'm still working on converting to the new models and verifying that doesn't break anything before adding new stuff |
- This commit fixes all bugs that changed the build outputs are unchanged through this PR
This PR refactors how our
beet.yaml
metadata is read into many of our build plugins, using the intended system of pydantic models rather than arbitrary dict access. This change allows for a much clearer definition of what options are available/expected and in what format.Also included in this PR (and its impetus), is the addition of the
search_keywords
config option for the website.