Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinitas Shamir: Update to 1.20 and leftover fixes #898

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

EpyonProjects
Copy link
Member

  • Actually works in 1.20, after including the required location tags
  • Addresses SneakingSpider's last mentioned issue regarding milk/cows
    • Turns out milk uses player_interacted_with_entity, not filled_bucket
  • Addresses rx's concern about the powder snow toggle
    • It is now off by default
  • Updates the bucket shamir nbt in init
    • As a result, this autoupdates pre-existing Infinitas buckets after use

- Actually works in 1.20, after including the required location tags
- Addresses SneakingSpider's last mentioned issue regarding milk/cows
  - Turns out milk uses player_interacted_with_entity, not filled_bucket
- Addresses rx's concern about the powder snow toggle
  - It is now off by default
- Updates the bucket shamir nbt in init
  - As a result, this autoupdates pre-existing Infinitas buckets after use
@misode misode changed the title Update to 1.20 and leftover fixes Update infinitas to 1.20 and leftover fixes Sep 9, 2023
@EpyonProjects EpyonProjects changed the title Update infinitas to 1.20 and leftover fixes Infinitas Shamir: Update to 1.20 and leftover fixes Sep 10, 2023
@Bloo-dev
Copy link
Member

Works as advertised, therefore it is ready to be merged.

A future PR should make it so that the lava toggle is loaded from the gamerule once upon first install. The same goes for a water toggle that should be added:

execute unless score $water_infinitas gm4_ml_data matches 0..1 store result score $water_infinitas gm4_ml_data run gamerule waterSourceConversion
execute unless score $lava_infinitas gm4_ml_data matches 0..1 store result score $lava_infinitas gm4_ml_data run gamerule lavaSourceConversion

At that point, only Milk wouldn't have a toggle so I suggest also adding one for milk.

@Bloo-dev Bloo-dev merged commit 42d0437 into Gamemode4Dev:master Sep 22, 2023
2 checks passed
@EpyonProjects EpyonProjects deleted the infinitas-fixes-1 branch February 20, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants