-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish libraries on smithed #889
Publish libraries on smithed #889
Conversation
Standalone library build, with needed lantern load files, saved to the release directory to be uploaded to smithed
509542c
to
33abb3f
Compare
Alright this marks the feature-completion of this PR. All that remains is making smithed pages for each library, and officially relicensing the libraries under MIT. Any contributor to the Gamemode 4 Libraries will be requested to signal their approval of the relicensing by submitting an "approve" review on this pull request. This relicensing only affects the contents |
I agree to license the libraries as MIT |
I approve the relicensing to MIT. My contributions may be freely used under the MIT License. |
I agree to relicensing the libraries to MIT. |
I agree to relicensing the libraries to MIT |
- actually offers explanations for things - restructures "Additional Uses" section
- adds example functions to show how to tag potions and how to execute from landed potions
- add loot table for example recipe - switch example to 1 wool -> 3 string to explain that rounding down is necessary
Fix some library readmes
Is there a reason the MIT license uses 2021? I'm not sure how the year works tho. If it's the first year the license is in affect or if it's the latest year the license has updated? |
Some people update it every year, others keep it as the initial year. Afaict it doesn't really matter (not legal advice). |
Simple inkscape-bitmap-traced icons. Do not conform with the GM4 color map and should be adjusted in the future. I blindly used the colorize filter to achieve this effect
Alright I've added some quick-and-dirty pack.pngs for the libraries (just so theyre not default). Please feel free to adjust the color palette in the future, I just used inkscapes colorize filter and it was close enough for now |
Aaaaaaand I did a self review and am going to merge this and fight whatever fires arise. Wish me luck :) |
This PR adds a step to our build pipeline that will upload standalone copies of our libraries to smithed for other developers to use 🎉
Although smithed has some dependency-listing capability, these library zips will come with any sub-libraries already included (lib_machines will include lib_forceload for example), since that works very cleanly with our build configs
As a part of the PR, we will be relicensing the libraries on our main repo under MIT. This was discussed and happened on the now abandoned separate repos some of our libraries can be found on in the past, but never was completed. All other content in this project will remain licensed under GPLv3, and only the contents of
lib_*
folders (which will each contain a copy of the MIT license) will be affected. As such all contributors to the libraries will be asked to approve this PR.