API endpoint for starting a game #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- forward the request to relevant socket.io event `game-start` - the use-case layer simply invokes `Game.start(player-id)` TODO - set up ready flag in `Player` model, avoid subsequent configuration after the flag is set - update Open API spec Signed-off-by: T.H. <[email protected]>
Signed-off-by: T.H. <[email protected]>
metalalive
added
documentation
Signed-off-by: T.H. <[email protected]>
wingtkw
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR :
Game.start(player-id)Gameinternally set ready flag inPlayerobject ,game-startI will merge the PR if nobody can help me review the code or give any feedback by 12:30 PM (GMT+8) 23th Feb. 2024.
c.c. @wingtkw , @KalpasWang