🏷️ add player and round type #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dlutermade
reviewed
Sep 24, 2023
| @@ -5,3 +5,12 @@ export type Player = { | |||
| hands: Card[]; | |||
| pastReceivedCards: Card[]; | |||
| }; | |||
|
|
|||
| export enum SelectedPlayerAction { | |||
Comment on lines
6
to
+8
| selectedPlayer: Player; | ||
| isGameEnd: boolean; | ||
| hasBeenSelectedPlayer: Player[]; |
There was a problem hiding this comment.
這邊已經有選擇玩家了
爾且選擇玩家應該是 SelectedPlayer
There was a problem hiding this comment.
我記得規則有不能傳給已經被傳過的玩家，所以想說需要 hasBeenSelectedPlayer 來紀錄已經被傳過的玩家，你覺得呢？
There was a problem hiding this comment.
這地方只需要在player裏面加上收過的卡片即可
因為玩家如果收過該卡片則不能被選擇
There was a problem hiding this comment.
喔喔我以為 postReceivedCard 是指玩家累積的明牌，那是否需要一個 type 是紀錄玩家累積的明牌? 我記得累積四種就算輸了
There was a problem hiding this comment.
他的type是Card 可以去看一下Card有沒有那些東西
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
If not, please ignore
What is the scope of this change?
backend
frontend