Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tabs component and page #406

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Conversation

JohnsonMao
Copy link
Contributor

@JohnsonMao JohnsonMao commented Oct 3, 2024

Why need this change? / Root cause:

  • 重構 Tabs component 以符合設計稿
  • 調整首頁與房間的頁面
  • 調整按鈕 disabled 樣式

Changes made:

  • Tabs (Component/Storybook)
  • index page
  • rooms page
  • room page

Test Scope / Change impact:

  • Tabs Component test

Issue

@JohnsonMao JohnsonMao self-assigned this Oct 3, 2024
@github-actions github-actions bot added the refactor refactor the changes already merged. label Oct 3, 2024
@JohnsonMao JohnsonMao changed the title refactor: tabs component refactor: tabs component and page Oct 3, 2024
Copy link

sonarqubecloud bot commented Oct 4, 2024

@GaaSBot
Copy link

GaaSBot commented Oct 4, 2024

Knip Scan Result for 683299c

Unused files (7)
Unused files (7)
.bundlewatch.config.js
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exports (1)
Unused exports (1)
default components/rooms/RoomChatroom/index.ts
Unused exported types (3)
Unused exported types (3)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (1)
Unused exported types in namespaces (1)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Oct 4, 2024

🤖 Lighthouse Scan Result for 683299c

/rooms
Metric Value
Performance 71
Seo 78
Accessibility 76
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 61
Seo 80
Accessibility 83
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 74
Seo 78
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit a784e02 into main Oct 4, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the refactor/tabs-component branch October 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the changes already merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rooms page home page Tabs Component
2 participants