Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try to read room info first before join room #403

Merged
merged 1 commit into from
Jul 28, 2024
Merged

feat: try to read room info first before join room #403

merged 1 commit into from
Jul 28, 2024

Conversation

noracami
Copy link
Contributor

Why need this change? / Root cause:

  • when user enter and leave the room page, they can not go back through current rooms page ui

Changes made:

  • check room info first, if success, means the user is already been in the room
  • try to previous process otherwise.

Test Scope / Change impact:

  • fetch api will alert status 400 in the console even catch it

Issue

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JohnsonMao JohnsonMao self-requested a review July 28, 2024 13:23
@JohnsonMao JohnsonMao self-assigned this Jul 28, 2024
@JohnsonMao JohnsonMao added the feature New Feature label Jul 28, 2024
@JohnsonMao JohnsonMao merged commit f9e4097 into Game-as-a-Service:main Jul 28, 2024
6 of 7 checks passed
@noracami noracami deleted the noracami-patch-1 branch July 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnsonMao JohnsonMao JohnsonMao approved these changes

Assignees

@JohnsonMao JohnsonMao

Labels
feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noracami @JohnsonMao