Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor icon stroke and storybook background #357

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • unable to change icon stroke color
  • storybook background match design

Changes made:

  • icon stroke color
  • storybook background

Test Scope / Change impact:

Issue

@JohnsonMao JohnsonMao added the refactor refactor the changes already merged. label Nov 19, 2023
@JohnsonMao JohnsonMao self-assigned this Nov 19, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Nov 19, 2023

Knip Scan Result for 472476d

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Nov 19, 2023

🤖 Lighthouse Scan Result for 472476d

/rooms
Metric Value
Performance 73
Seo 78
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 77
Seo 78
Accessibility 64
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 47
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@Yuwen-ctw
Copy link
Contributor

Hello @JohnsonMao ,觀察 storyBook 的呈現後(如下圖),似乎尚有兩個 svg 檔案可以設定其預設的 stroke,分別是 navArrowLeft 及 sent,想詢問是否須一併調整呢?
image

PS. 四個第三方登入的 Icon,似乎得用 fill 屬性來進行設定,故先忽略。

@JohnsonMao
Copy link
Contributor Author

Reply to @Yuwen-ctw

Hello @JohnsonMao ,觀察 storyBook 的呈現後(如下圖),似乎尚有兩個 svg 檔案可以設定其預設的 stroke,分別是 navArrowLeft 及 sent,想詢問是否須一併調整呢? image

PS. 四個第三方登入的 Icon,似乎得用 fill 屬性來進行設定,故先忽略。

感謝你的回覆~
我在另一個分支 (#356 ) 已經有先修改那兩個 icon 了,所以這兩個沒特別修改避免合併衝突

Copy link
Contributor

@Yuwen-ctw Yuwen-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnsonMao JohnsonMao merged commit 5cc717e into main Nov 22, 2023
8 checks passed
@JohnsonMao JohnsonMao deleted the refactor/icon branch November 22, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the changes already merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants