Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependabot ci failure issue #331

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

ttpss930141011
Copy link
Contributor

@ttpss930141011 ttpss930141011 commented Oct 6, 2023

Why need this change?:

  • The PR Auto Labeler / label (pull_request) CI in PR rised by dependabot would fail.

Root cause:

  • We didn't accept the PR title chore(deps) or chore(deps-dev) in auto-label workflow.

Changes made:

  • In order to follow this rule of naming dependent robots, I added [DEPENDA-BOT] in dependabot config file, and added labelsRules in auto-label.ci to detect PR prefix.

ref: commit-message

Test Scope / Change impact:

Issue

Notes

In fact, I rised the same PR #302 before, but it exceeded my expectations because it rised a lot of PRs to update the package like RENOVATE-BOT (and actually the PR prefix was wrong XD). So I reverted that PR finally.

image

In this PR, I added open-pull-requests-limit: 0 in config. This setting will prevent dependabot from making PRs except for some security exceptions that must be updated.

ref: How to get dependabot to trigger for security updates only

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Oct 6, 2023 6:49pm

@github-actions github-actions bot added the bug Fix something in main label Oct 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@GaaSBot
Copy link

GaaSBot commented Oct 6, 2023

Knip Scan Result for 6ac3497

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@ttpss930141011 ttpss930141011 self-assigned this Oct 6, 2023
@GaaSBot
Copy link

GaaSBot commented Oct 6, 2023

🤖 Lighthouse Scan Result for 6ac3497

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 77
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 74
Seo 80
Accessibility 66
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 46
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit eadd9c7 into main Oct 10, 2023
13 checks passed
@JohnsonMao JohnsonMao deleted the fix/dependabot-ci-failure-issue branch October 10, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants